|WARNING| [v2] net/bnxt: validate pool index in pool manager APIs

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171115

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-13

# DPDK Patch Review

## Errors

None identified.

## Warnings

**Warning 1: Missing release notes update**

The patch adds bounds checking to pool manager APIs, which is a bug fix for a potential out-of-bounds access. Since this fixes CVE-class behavior (array index from untrusted input used without validation), it should be documented in the current release notes under "Fixed Issues" or "Drivers" section.

**Suggested fix:** Add entry to `doc/guides/rel_notes/release_26_11.rst` (or current release) documenting the fix.

## Info

**Info 1: Error message format inconsistency (pre-existing)**

The new error messages use format string `"pool_id (%u) out of range (max %u)\n"` with `pool_id` and `ctx->max_pools` both as `uint16_t`. The existing error messages in the same file use `%d` for `pool_id` and `fid`:

```c
CFA_LOG_ERR("A function (%d) is still using the pool (%d)\n",
            ctx->fid_tbl[pool_id], pool_id);
CFA_LOG_ERR("Pool id (%d) was not allocated\n", pool_id);
```

While `%u` is more correct for unsigned types, mixing `%u` and `%d` for the same variable type (`uint16_t pool_id`) creates inconsistency. Consider using `%u` uniformly for unsigned values, or `%d` to match existing style in this file. This is pre-existing inconsistency that the patch perpetuates rather than introduces.

**Info 2: Defensive coding observation**

The bounds check `pool_id >= ctx->max_pools` correctly validates the index before it is used in array accesses (`ctx->fid_tbl[pool_id]`, `ba_inuse(ctx->pool_ba, pool_id)`). This prevents potential out-of-bounds access if a caller supplies an invalid pool_id. The check is placed appropriately before the array operations.

Review-Result: WARNING