|WARNING| [RFC, 2/2] test/transceiver: move module EEPROM decoding tests

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171257

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-14

# DPDK Patch Review

## PATCH 1/2: transceiver: introduce module EEPROM decoding library

### ERRORS

**1. Missing release notes**

The patch adds a new experimental library (`lib/transceiver/`) and introduces a new public API (`rte_transceiver_decode()`). This requires an entry in the release notes documenting the new library and API.

```c
/* Missing: doc/guides/rel_notes/release_27_03.rst update */
```

The release notes should describe:
- New transceiver library for SFF module EEPROM decoding
- New experimental API `rte_transceiver_decode()`
- Migration of SFF decoder code from ethdev to transceiver library

**2. Version map generation requires version.map file**

The patch uses `RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_transceiver_decode, 27.03)` in `lib/transceiver/rte_transceiver.c`, but according to the guidelines, this requires a `version.map` file to exist (even if auto-generated). The `lib/transceiver/meson.build` should declare this:

```python
# lib/transceiver/meson.build should include:
version_file = 'version.map'
```

Without this, the symbol export mechanism may not function correctly.

---

## PATCH 2/2: test/transceiver: move module EEPROM decoding tests

### No issues found in this patch.

The patch correctly:
- Moves tests to the new library location
- Updates test names and registration
- Retains a wrapper test for the ethdev API
- Uses appropriate `RTE_TRANSCEIVER_*` constants
- Maintains test coverage

---

## Summary

Both patches demonstrate good code organization and follow most DPDK conventions. The main issues are:

1. Missing release notes documentation for the new library and API (Error - required for new libraries)
2. Missing version.map declaration in meson.build (Error - required for symbol export)

The code quality is high with no correctness bugs, proper API design, clear documentation, and comprehensive test coverage.

Review-Result: ERROR