|SUCCESS| net/iavf: fix interrupt callback race on close

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Wed Oct 14 15:38:12 CEST 2026


Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171276

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-14

# Review of DPDK Patch: net/iavf interrupt callback race fix

## ERRORS

None.

## WARNINGS

None.

## INFO

**Note on sync unregister safety:**
The commit message states that `rte_intr_callback_unregister_sync()` is safe because `iavf_dev_interrupt_handler()` never closes or re-initializes the port directly -- it delegates PF events and resets to the `iavf-event` thread via `iavf_dev_event_post()`. This is correct reasoning: the sync variant would deadlock only if called from within the very callback being unregistered, and the explanation confirms that does not happen here.

The pattern matches `drivers/net/ice/ice_ethdev.c` which uses `rte_intr_callback_unregister_sync()` in `ice_dev_close()` at line 2893 for the same reason.

**Evidence base:**
This review is based on the patch diff only. The claim about `iavf_dev_interrupt_handler()` behavior and the `ice_dev_close()` precedent rest on familiarity with DPDK driver patterns, not on having opened those files during this review.

Review-Result: CLEAN


More information about the test-report mailing list