|WARNING| vhost: make cryptodev support optional

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171345

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-14

# DPDK Patch Review

## Errors

None identified.

## Warnings

**Missing release notes entry**

The patch makes a significant change to library configuration by making cryptodev support optional in vhost. This is a user-visible change that affects which APIs are available when `RTE_LIB_CRYPTODEV` is disabled. A release notes entry should document this new build-time optionality.

Suggested fix: Add an entry to `doc/guides/rel_notes/release_26_11.rst` (or the current release file) under a "Library Changes" or similar section:

```rst
* **Made vhost cryptodev support optional.**

  The vhost library's cryptodev support can now be disabled at build time
  when ``RTE_LIB_CRYPTODEV`` is not enabled. When disabled, ``rte_vhost_crypto.h``
  will not be installed and crypto-related vhost functions will not be available.
```

## Info

None.

---

**Analysis:**

The patch conditionally compiles `vhost_crypto.c` and exports `rte_vhost_crypto.h` based on whether `RTE_LIB_CRYPTODEV` is enabled. This is a straightforward build configuration change with no code modifications.

**Correctness:** No code changes are introduced that could cause bugs. The conditional compilation uses standard meson patterns already present throughout DPDK.

**Style:** Meson build file formatting is correct (4-space indentation, proper list formatting with trailing comma).

**API:** The public API is conditionally available. This is acceptable for optional features, but should be documented in release notes so users know that disabling cryptodev means losing vhost crypto APIs.

**Process:** The change removes `'cryptodev'` and `'hash'` from unconditional deps and re-adds them only when cryptodev is enabled. The dependencies are correctly scoped.

Review-Result: WARNING