|WARNING| [16/16] bus/fslmc: use generic cleanup

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171370

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-14

# DPDK Patch Review

## Patch 01/16: drivers/bus: cleanup device freeing in NXP bus scan

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 02/16: drivers/bus: fix FD leak during scan in NXP drivers

### Errors

1. **Error path closes wrong fd in dpaa_bus.c:**
   ```c
   if (rte_intr_fd_set(intr_handle, fd) ||
           rte_intr_type_set(intr_handle, RTE_INTR_HANDLE_EXT)) {
       int err = -rte_errno;
   
       close(fd);
       rte_intr_fd_set(intr_handle, -1);
       return err;
   }
   ```
   If `rte_intr_fd_set()` succeeds but `rte_intr_type_set()` fails, the fd was successfully stored in the handle and should not be closed here -- the close would leak a descriptor stored in the handle and close a stale local variable. The correct fix is to check each call separately and only close on failure of the first call.

### Warnings

None.

### Info

None.

---

## Patch 03/16: bus/dpaa: allocate interrupt during probing

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 04/16: bus/dpaa: support unplug and use generic cleanup

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 05/16: bus/fslmc: fix device name leak

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 06/16: bus/fslmc: fix memory leaks in scan

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 07/16: bus/fslmc: fix per type device count

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 08/16: bus/fslmc: fix some VFIO device FD and memory leaks

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 09/16: bus/fslmc: fix interrupt leak in DPIO cleanup

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 10/16: bus/fslmc: simplify device parsing in scan

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 11/16: bus/fslmc: release resources on probe failure

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 12/16: bus/fslmc: refactor device filtering for multiprocess

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 13/16: bus/fslmc: move unplug for some device out of VFIO

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 14/16: bus/fslmc: call VFIO setup for some device from bus layer

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 15/16: bus/fslmc: allocate interrupt during probing

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 16/16: bus/fslmc: use generic cleanup

### Errors

None.

### Warnings

None.

### Info

None.

---

Review-Result: ERROR