|SUCCESS| [v2,3/3] eal: enforce internal API check with Clang 14

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171413

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15

# DPDK Patch Review

## PATCH 1/3: buildtools/chkincs: relax checks on driver headers

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 2/3: eal: simplify internal/experimental tags definitions

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 3/3: eal: enforce internal API check with Clang 14

### Errors

None.

### Warnings

None.

### Info

None.

---

## Summary

All three patches are clean. The series makes reasonable changes to the build system and internal API checking:

1. **Patch 1** relaxes header compilation checks for driver headers, recognizing that driver headers legitimately use internal APIs. The change removes redundant build targets and consolidates on `ALLOW_INTERNAL_API`.

2. **Patch 2** is a readability refactor of the `__rte_experimental` and `__rte_internal` macro definitions. The logic is preserved while the structure is clarified: MSVC first (no diagnostics), then for other toolchains handle the `!ALLOW_*` cases with diagnostics, falling back to section placement.

3. **Patch 3** improves internal API checking by preferring Clang's `diagnose_if` attribute over `error` attribute. The commit message explains the motivation: `diagnose_if` provides stricter checking because it diagnoses before optimization, whereas `error` only catches calls that survive optimization.

All patches are correctly structured, compile-tested per the guidelines, and documentation is appropriately minimal for build system changes. No correctness issues, style violations, or guideline problems detected.

Review-Result: CLEAN