|SUCCESS| [v2,3/3] eal: enforce internal API check with Clang 14

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171413

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15

# DPDK Patch Review

## Patch 1/3: buildtools/chkincs: relax checks on driver headers

### ERRORS

None identified.

### WARNINGS

None identified.

### INFO

None identified.

---

## Patch 2/3: eal: simplify internal/experimental tags definitions

### ERRORS

None identified.

### WARNINGS

None identified.

### INFO

The restructuring improves readability by grouping MSVC separately and organizing each tag's definition by compiler capability in a consistent order. The logic remains equivalent to the original.

---

## Patch 3/3: eal: enforce internal API check with Clang 14

### ERRORS

None identified.

### WARNINGS

None identified.

### INFO

The reordering from `error`-then-`diagnose_if` to `diagnose_if`-then-`error` is intentional: `diagnose_if` catches calls before optimization (stronger diagnostic), while `error` only catches calls that remain after optimization (weaker, misses inlined/eliminated calls). Preferring `diagnose_if` when available (Clang) over `error` (GCC fallback) strengthens the check without changing the GCC behavior.

The `Fixes:` tag and `Cc: stable at dpdk.org` are present, which is correct for a bug fix being backported.

---

Review-Result: CLEAN