|SUCCESS| [v1,1/1] net/iavf: remove dead code

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171461

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15

# DPDK Patch Review

## Patch: net/iavf: remove dead code

This patch removes commented-out debug code and a related comment from the iavf driver's Rx queue interrupt configuration path.

---

## CORRECTNESS BUGS

None identified.

---

## WARNINGS

**Dead store before removal (pre-existing, not introduced by this patch)**

In the code surrounding the removed lines, there is a write to a register:

```c
IAVF_WRITE_REG(hw, IAVF_VFINT_DYN_CTLN1(msix_vect - IAVF_RX_VEC_START),
               (0 << IAVF_VFINT_DYN_CTLN1_ITR_INDX_SHIFT) |
               IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK |
               (2UL << IAVF_VFINT_DYN_CTLN1_INTERVAL_SHIFT));
```

The removed comment suggests there was an intention to verify this write succeeded via:
```c
/* IAVF_READ_REG(hw, IAVF_VFINT_ITRN1(0, 0)); */
```

However, this is **pre-existing** to the patch. The patch simply removes dead/commented-out code. The register write itself is not validated, but this was already the case before the patch. The removal of the commented-out verification does not change the runtime behavior.

Note: If register write verification was intended, it should be done via an active read-back, not a commented-out one. However, this is a cleanup patch removing dead code, not introducing new issues.

---

## INFO

**Comment removal is appropriate**

The removed comment references code that is being deleted (the commented-out `IAVF_READ_REG`). Removing both the comment and the dead code together is correct.

**Patch does not introduce new issues**

This is a pure code deletion patch. All removed lines are either:
- Comments describing dead code
- Commented-out register read (dead code)

The patch improves code cleanliness by removing debug scaffolding that was never enabled.

---

Review-Result: CLEAN