|SUCCESS| ci: fix dependency on cmdline

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Thu Oct 15 19:23:50 CEST 2026


Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171463

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15

# DPDK Patch Review

## ERRORS

None.

## WARNINGS

None.

## INFO

**CI build script adjustment**

The patch changes the MINI build configuration from disabling all libraries (`-Ddisable_libs=*`) to enabling only cmdline (`-Denable_libs=cmdline`). This is a meaningful semantic difference:

- Old: build all libs except those explicitly disabled (none listed - builds everything)
- New: build only cmdline (and its dependencies)

The commit message states "unit tests, testpmd and some examples depend on cmdline" but does not explain whether other libraries beyond cmdline are needed for the MINI target to function. If EAL, mempool, mbuf, ethdev, or other core libraries are required by the enabled components (net/null driver, l2fwd example, unit tests, testpmd), the new setting may be insufficient.

**Suggested verification**: Confirm that `enable_libs=cmdline` causes meson to also build all transitive dependencies required by:
- `net/null` driver
- `l2fwd` example (when `DEF_LIB=static`)
- The unit test suite
- testpmd

If meson automatically enables dependency libraries, the change is correct. If it does not, additional libraries may need to be listed.

Note: This is an observation about build system semantics, not a code correctness issue. The patch itself is syntactically correct and follows DPDK style for shell scripts.

Review-Result: CLEAN


More information about the test-report mailing list