|SUCCESS| [v27, 25/25] doc: update release notes with NXP DPAA changes

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171519

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-16

Review of DPDK patch series v27 (patches 01-25).

---

## **Patch 01/25: net/dpaa: fix double close and null deref on remove**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The fix is correct and addresses the described issues. The patch removes the unconditional close, adds a NULL check on `eth_dev`, and logs the close result. The release is returned regardless of close status, as documented.

---

## **Patch 02/25: net/dpaa: fix probe success when FMC init fails**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch correctly sets `ret` to `num_rx_fqs` when `dpaa_port_fmc_init()` fails, propagating the error code instead of returning success.

---

## **Patch 03/25: net/dpaa: fix resource leak on probe failure**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch correctly unwinds through `close_dev` and `release_port` labels on mempool creation failure, matching the existing cleanup pattern.

---

## **Patch 04/25: net/dpaa: fix free port resources on close**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch adds cleanup of `tx_conf_queues` in `dpaa_eth_dev_close()` and on probe failure paths, and moves the cleanup label in `dpaa_dev_init()` to release `tx_conf_queues` before `tx_queues`. The cleanup is correct.

---

## **Patch 05/25: bus/dpaa: fix FQD dest wq channel decoding**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch corrects the bit extraction: the work queue is bits 2:0, the channel is bits 15:3. The old code extracted a 0-7 value as the channel, which could never match the pool-channel range. The fix adds helper functions `qm_fqd_get_chan()` and `qm_fqd_get_wq()` and uses them in `qman_shutdown_fq()`.

---

## **Patch 06/25: bus/dpaa: fix hang on FQ shutdown**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch changes `qman_shutdown_fq()` to take a `struct qman_fq *` and use `fq->qp` when available, falling back to the affine portal otherwise. It adds bounds checking for the channel, rejects channels that cannot be drained from software, and limits the wait for FQRN to `QMAN_FQRN_WAIT_MAX`. The portal SDQCR is restored on all paths. The changes are correct.

---

## **Patch 07/25: mempool/dpaa: fix write after free on pool free**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch fixes the use-after-free by clearing `bp_info->bp` before `rte_free(bp_info)` and freeing `bp_info` directly instead of the alias `mp->pool_data`.

---

## **Patch 08/25: dma/dpaa: fix data validation on the completion path**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch gates `fsl_qdma_data_validation()` behind `s_data_validation`, which is off by default, so the byte-by-byte compare is skipped unless explicitly requested.

---

## **Patch 09/25: net/dpaa: prefix fmlib device helpers**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch renames `create_device()` and `get_device_id()` to `fm_create_device()` and `fm_get_device_id()` to avoid clashing with other drivers when DPDK is linked statically. The changes are correct.

---

## **Patch 10/25: bus/dpaa: accept QDMA device name in devargs**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch parses `dpaa_qdma-N` in `rte_dpaa_bus_parse()`, bounding the index by `RTE_DPAA_QDMA_DEVICES`, so QDMA devargs can be passed.

---

## **Patch 11/25: bus/dpaa: refine fman naming**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch renames `ccsr_map` to `memac_map` and `bmi_map` to `rx_bmi_map` for clarity.

---

## **Patch 12/25: bus/dpaa: scan max BPID from DTS**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch reads the BPID range from the `fsl,bpid-range` device tree property and clamps it to `BMAN_MAX_POOLS`. The changes are correct.

---

## **Patch 13/25: drivers: add process-type guards for secondary process**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch adds process-type guards to reject secondary process probes in `dpaa_qdma_probe()` and to skip primary-only bookkeeping in `rte_dpaa_remove()` for secondaries. The changes are correct.

---

## **Patch 14/25: bus/dpaa: scan pool channel range from DTS**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch reads the pool channel range from the `fsl,pool-channel-range` device tree property, validates it, and uses it in `qman_shutdown_fq()` instead of a hardcoded 15. The changes are correct.

---

## **Patch 15/25: drivers: add BMI Tx statistics**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch adds support for BMI Tx statistics counters and extends `fman_if_bmi_stats_get_all()` to read them. The changes are correct.

---

## **Patch 16/25: net/dpaa: optimize FM deconfig**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch consolidates FM deconfiguration to avoid duplicate calls and moves the `fm_deconfig` call to a single location. The changes are correct.

---

## **Patch 17/25: net/dpaa: optimize FMC MAC type parsing**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch adds a helper `dpaa_port_fmc_get_idx_from_name()` to parse the MAC index from the port name instead of relying on the MAC type and port number. The changes are correct.

---

## **Patch 18/25: drivers: release DPAA bpid on driver destructor**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch adds a driver destructor that releases allocated BPIDs at exit, tracking them in a static table. The changes are correct.

---

## **Patch 19/25: dma/dpaa: add devargs for SG and errata workaround**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch adds device arguments to control scatter-gather batching, data validation, and the ERR050757 workaround at runtime. The changes are correct.

---

## **Patch 20/25: net/dpaa: create max Rx queues in FMCLESS mode**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch changes the number of Rx queues in FMCLESS mode to `DPAA_MAX_NUM_PCD_QUEUES` instead of `rte_lcore_count()`. The changes are correct.

---

## **Patch 21/25: bus/dpaa: optimize DPAA multi-entry buffer pool operations**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch adds a big-endian hardware buffer descriptor overlay and helper functions to build and parse release/acquire entries in a single 8-byte access. The changes are correct.

---

## **Patch 22/25: bus/dpaa: improve log macro usages**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch replaces `DPAA_BUS_LOG(LEVEL, ...)` calls with shorthand macros for consistency. The changes are correct.

---

## **Patch 23/25: net/dpaa: enhance VSP port support**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch maps `fman_onic` to `OH_OFFLINE_PARSING`, replaces parallel arrays with a `struct dpaa_if_vsp`, bounds the VSP ID, and handles the shared-MAC base profile before freeing handles. The changes are correct.

---

## **Patch 24/25: drivers: improve DPAA crypto fq resource handling**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch releases resources on probe failure and on uninit, allocates the FQID range with a single ioctl, and releases FQIDs only after their queues shut down. The changes are correct.

---

## **Patch 25/25: doc: update release notes with NXP DPAA changes**

**Errors:**

None.

**Warnings:**

None.

**Info:**

The patch adds a single "Updated NXP DPAA drivers" entry to the release notes with sub-bullets describing the changes.

---

Review-Result: CLEAN