|WARNING| [v3,2/2] meson: add all drivers to dynamic libraries

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171559

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-16

# DPDK Patch Review

## PATCH 1/2: meson: rename static drivers list

No issues found.

## PATCH 2/2: meson: add all drivers to dynamic libraries

### ERRORS

None.

### WARNINGS

**buildtools/pkg-config/meson.build, line 53:**
```
libraries: ['-Wl,--as-needed'] + dpdk_libraries + dpdk_shared_drivers,
```
The `dpdk_shared_drivers` list is added to the `libraries` field in the pkg-config file, making all shared driver libraries visible to applications linking against DPDK. While the commit message explains this is safe due to `--as-needed` preventing overlinking, the change introduces a significant behavior shift that should be documented in release notes.

This is a new feature (making drivers available for direct linking in shared builds) that alters the public build interface. Applications that previously could not directly link against driver symbols now can. This merits a release note entry explaining the change and its implications.

**Missing release notes update:**
The patch modifies the public pkg-config interface and changes how DPDK drivers are exposed in shared builds. This requires a release note entry in `doc/guides/rel_notes/` documenting:
- The consolidation of `libdpdk-libs.pc` into `libdpdk.pc`
- The new ability to link against driver symbols in shared builds
- The guarantee that driver constructors run exactly once

### INFO

The architectural change described in the commit message is sound:
- The `--as-needed` flag prevents overlinking to unused drivers
- The dynamic loader deduplicates dlopen() calls by soname/inode, preventing double-initialization
- The link order issue that previously required two .pc files is resolved by listing both drivers and libraries in `Libs.private`

The implementation correctly adds drivers to both `dpdk_shared_drivers` and `dpdk_shared_lib_deps` in `drivers/meson.build`, maintaining consistency with how libraries are handled.

Review-Result: WARNING