|SUCCESS| net/dpaa: make mac_idx static

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171564

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-16

# Review of DPDK Patch: net/dpaa: make mac_idx static

## Analysis

This patch adds the `static` keyword to the `mac_idx` array in `drivers/net/dpaa/dpaa_flow.c`.

### Correctness Review

No correctness bugs identified. The change from a global symbol to file-scope static does not introduce:
- Resource leaks
- Use-after-free
- Race conditions
- Logic errors
- Missing error checks

The array is `const` and contains compile-time constant values, so making it `static` is purely a scope reduction with no runtime impact.

### Code Style Review

**Good practice:** This follows the guideline that driver global variables should use unique prefixes to avoid namespace collisions when statically linked. By making this array `static` (file scope only), the patch eliminates the need for a driver-specific prefix since the symbol is no longer exported.

The array is properly declared as `const` (immutable lookup table), which is correct per the "Non-const Function Pointer Arrays" guideline.

### API and Documentation Review

No API changes. No documentation updates required (internal driver change only).

### Build and Process Review

The change does not affect:
- ABI compatibility (internal symbol, not exported)
- Compilation (reduces symbol visibility, cannot break existing code)
- Testing requirements (internal refactoring only)

## Summary

This is a clean internal refactoring that improves code hygiene by limiting symbol scope to file-local where it is actually used. The change prevents potential symbol name collisions with other DPDK drivers when statically linked.

Review-Result: CLEAN