|WARNING| net/dpaa: make mac_idx static

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171564

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-16

# DPDK Patch Review

## Analysis

This patch changes a global array `mac_idx` to have static linkage by adding the `static` keyword.

### Evidence Check

The patch modifies line 37 of `drivers/net/dpaa/dpaa_flow.c`:
- Before: `const uint8_t mac_idx[] = {-1, 0, 1, 2, 3, 4, 5, 6, 7, 0, 1};`
- After: `static const uint8_t mac_idx[] = {-1, 0, 1, 2, 3, 4, 5, 6, 7, 0, 1};`

The commit message states "This array is only used in this file," which is a claim about code scope. Without reading the entire driver to verify no external references exist, this claim cannot be confirmed from the patch alone. However, the change itself is observable: adding `static` to a file-scope array.

### Correctness Review

**No correctness issues identified.**

The patch does not change behavior for correct usage (where the array is indeed file-local). If the array was genuinely used elsewhere, this would cause a link error, making it a build-time issue rather than a runtime correctness bug.

### Style and Naming Review

**Error: Global variable lacks unique driver prefix**

Line 37 (new):
```c
static const uint8_t mac_idx[] = {-1, 0, 1, 2, 3, 4, 5, 6, 7, 0, 1};
```

The symbol `mac_idx` is too generic. Even though it is now `static` (file-scoped), DPDK naming guidelines require driver-specific prefixes for global variables to prevent namespace collisions during static linking. The dpaa driver should use a `dpaa_` prefix.

**Suggested fix:**
```c
static const uint8_t dpaa_mac_idx[] = {-1, 0, 1, 2, 3, 4, 5, 6, 7, 0, 1};
```

All references to `mac_idx` in `dpaa_flow.c` would need to be updated to `dpaa_mac_idx`.

Note: The guidelines state "Drivers and libraries must not expose global variables that could clash when statically linked" and provide examples showing driver-specific prefixes (`virtio_`, `mlx5_`). While `static` limits scope to the file, the prefix convention improves code clarity and maintains consistency with the broader DPDK codebase.

### Additional Observations

The array contains a suspicious first element `-1` which will be stored as `255` in a `uint8_t` due to unsigned wraparound. This appears intentional based on the comment "0 is unused" but is a pre-existing pattern not introduced by this patch.

---

## Summary

**Errors:**
- Global variable uses generic name `mac_idx` instead of driver-prefixed `dpaa_mac_idx`

Review-Result: ERROR