|SUCCESS| test: defer timer initialization

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171582

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-17

# DPDK Patch Review

## ERRORS

None identified.

## WARNINGS

None identified.

## INFO

**test/test_pdcp.c: Timer subsystem initialization**
Line: `ret = rte_timer_subsystem_init();`

This is a correct pattern. The patch moves timer subsystem initialization from a global unconditional init in `main()` to per-test initialization only when needed. The error handling checks both for failure (`ret < 0`) and the already-initialized case (`ret != -EALREADY`), which is appropriate since multiple tests may call this in sequence.

**test/test_timer.c, test_timer_perf.c, test_timer_racecond.c, test_timer_secondary.c: Consistent initialization pattern**
All timer-related tests now follow the same initialization pattern:
```c
ret = rte_timer_subsystem_init();
if (ret < 0 && ret != -EALREADY) {
    printf("timer subsystem init failed: %d\n", ret);
    return TEST_FAILED;
}
```

This is correct and consistent. The check for `-EALREADY` allows tests to be robust if the subsystem is already initialized by an earlier test in the same run.

**Memory optimization benefit**
The patch description states this removes an unconditional 3MB memzone allocation on ARM and helps tests running in legacy mem mode with tight memory budgets. This is a valid optimization that reduces resource usage for tests that don't need timers.

**Release notes**
No release notes are needed for this test-only change. This is an internal improvement to the test infrastructure, not a change to public API or user-visible behavior.

Review-Result: CLEAN