|WARNING| net/vhost: fix SW checksum when zero

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171583

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-17

# DPDK Patch Review

## ERRORS

### 1. Incorrect Boolean Logic - Explicit Comparison Required

**File:** drivers/net/vhost/rte_eth_vhost.c  
**Lines:** 349, 392

The conditions `unlikely(csum == 0)` are used without explicit comparison against a boolean type. The DPDK coding standard requires explicit comparisons for integers: `if (csum == 0)` not `if (!csum)`, and `unlikely()` should wrap the entire comparison, not just part of it.

**Current code:**
```c
if (unlikely(csum == 0) && (mbuf->packet_type & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_UDP)
```

**Should be:**
```c
if (unlikely(csum == 0 && (mbuf->packet_type & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_UDP))
```

Or for clarity with explicit comparison style:
```c
if (unlikely((csum == 0) && ((mbuf->packet_type & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_UDP)))
```

The `unlikely()` wrapper should encompass the entire compound condition that is unlikely, not just one operand. As written, only the first part of the AND expression is marked unlikely, which defeats the branch prediction hint when both conditions need to be true.

---

## WARNINGS

None identified.

---

## INFO

### Code Correctness Verification

The fix correctly addresses the bug described in the commit message:

1. **Original bug:** `(mbuf->packet_type & RTE_PTYPE_L4_UDP)` incorrectly matched any packet type with bit 0x200 set, not just UDP packets.

2. **Fix:** `(mbuf->packet_type & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_UDP` properly isolates the L4 protocol field and compares against UDP specifically.

3. **UDP checksum zero handling:** RFC 768 requires UDP checksums of zero to be transmitted as 0xffff. The logic correctly applies this only to UDP packets after the fix.

The patch correctly targets both Tx and Rx paths (lines 349 and 392) with identical fixes.

### Release Notes

Since this is a bug fix with a `Fixes:` tag and `Cc: stable at dpdk.org`, it does not require release notes per the guidelines (bug fixes to stable branches don't need release notes in the main branch).

---

Review-Result: ERROR