|SUCCESS| [v4, 10/10] net/gve: enforce DQO TSO header and length limits

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171639

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-19

# DPDK Patch Review

## PATCH 01/10: net/gve: fix DQO descriptor cleaning loop bound

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly fixes an off-by-one error in the loop condition.
The pre-decrement `--nb_descs` evaluates the new value before the loop body,
so when `nb_descs` is 1, it becomes 0 (false) and the loop does not run.
The post-decrement `nb_descs--` evaluates to the old value before decrementing,
so the loop runs exactly `nb_descs` times as intended.

---

## PATCH 02/10: net/gve: fix DQO completion queue stall on unknown type

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly fixes the stall: returning early without advancing `complq_tail`
causes every later call to stop at the same unknown entry.
Logging the type and continuing past it is the correct fix.

---

## PATCH 03/10: net/gve: fix DQO Tx report event interval

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly fixes the descriptor completion request logic.
The old code requested a completion every 32 packets, which fails when multi-segment
or TSO packets fill the ring before 32 packets are posted.
The new code requests a completion once `GVE_TX_MIN_RE_INTERVAL` descriptors
have been posted since the last request, matching the Linux driver.

The `re_cnt` field is removed and replaced with `last_re_idx`,
which tracks the last descriptor index where a report event was requested.
This is correctly initialized to 0 in `gve_reset_tx_ring_state_dqo()`.

---

## PATCH 04/10: net/gve: fix stray TSO context descriptor on tag exhaustion

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly fixes the order: the completion tag must be allocated
before writing any descriptor, so that if allocation fails,
no descriptor is left in the ring.

---

## PATCH 05/10: net/gve: add cacheline overlap margin to DQO Tx ring

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly adds the cacheline overlap margin to the ring space check.
The device prefetches descriptors in cacheline units (64 bytes = 4 descriptors),
so when producer tail and consumer head share a cacheline,
CPU and device DMA can collide.
The fix requires `GVE_TX_MIN_DESC_PREVENT_CACHE_OVERLAP` (4 descriptors) headroom,
matching the Linux driver.

---

## PATCH 06/10: net/gve: fix Tx stall on invalid packets

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly fixes the Tx stall caused by invalid packets.
The old code stopped the burst without consuming the packet,
so the application retried it forever.
The new code frees invalid packets and continues with the burst.

The validation is moved before the ring space check,
so oversized packets are dropped instead of stopping the burst there.
The `invalid_mbufs` counter is added for `rte_mbuf_check()` failures.

The `nb_sent` variable is introduced to count packets actually posted to the ring,
distinguishing them from packets dropped as invalid.
Statistics are updated correctly: `packets` counts `nb_sent`, `errors` counts `nb_pkts - nb_sent`.

---

## PATCH 07/10: net/gve: export Tx drop counters in xstats

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly exports the `too_many_descs` and `invalid_mbufs` counters
in the Tx xstats table, making them readable.

---

## PATCH 08/10: net/gve: reject Tx packets that cannot fit in the ring

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly adds a maximum packet descriptor check.
A TSO packet needing more descriptors than the ring can ever have free
fails the ring space check on every burst and blocks the queue.
The new `gve_tx_max_pkt_descs()` helper calculates the maximum:
ring size minus 1 (always reserved), minus the cacheline overlap margin,
minus `GVE_TX_MIN_RE_INTERVAL - 1` (posted descriptors not yet reclaimed).

Packets exceeding this limit are dropped and counted as `too_many_descs`.

---

## PATCH 09/10: net/gve: enforce DQO Tx packet length limits

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly enforces the device limits for non-TSO packets:
17 to 9728 bytes as noted in the Linux driver.
Packets outside this range are dropped and counted in a new `invalid_pkts` counter.

The validation is done before the ring space check,
so invalid packets are dropped instead of stopping the burst.

---

## PATCH 10/10: net/gve: enforce DQO TSO header and length limits

**Errors:**

None.

**Warnings:**

None.

**Info:**

None.

This patch correctly enforces the device limits for TSO packets:
MSS of 88 to 9728 bytes, payload up to 262143 bytes, and headers up to 255 bytes.
Headers must be contained in the first segment and not be empty.

Packets violating these limits are dropped and counted as `invalid_pkts`.

The fixes prevent divide-by-zero when `tso_segsz` is 0,
header truncation when headers exceed 255 bytes,
and incorrect validation when headers span segments.

---

Review-Result: CLEAN