|WARNING| net/gve: advertise Rx scatter in GQI queue format
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Mon Oct 19 14:40:59 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171640
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-19
# DPDK Patch Review
## Summary
This patch adds advertisement of `RTE_ETH_RX_OFFLOAD_SCATTER` capability for the GVE driver in GQI mode, fixing an issue where applications that check capabilities before enabling multi-segment Rx would fail to process jumbo frames correctly.
## ERRORS
None identified.
## WARNINGS
**Missing release notes update:**
The patch adds a new Rx offload capability (`RTE_ETH_RX_OFFLOAD_SCATTER`) for GQI mode, which is a user-visible behavior change. This should be documented in the release notes. The API itself is not new, but the driver's advertised capabilities are changing, which affects how applications configure the device.
Add an entry to `doc/guides/rel_notes/release_XX_XX.rst` (where XX_XX is the target release) under the "drivers/net" section noting that GQI mode now advertises scatter Rx capability.
## INFO
**Documentation completeness (pre-existing):**
The features matrix update correctly marks "Scattered Rx" as "P" (partially supported - GQI only, not DQO), which is accurate. The inline comment in the code clearly explains when scatter is supported. No issues with the documentation aspect of this patch.
**Code correctness:**
The conditional logic is correct - `gve_is_gqi(priv)` properly restricts the scatter capability to GQI mode only, matching the commit message's statement that "DQO posts one buffer per packet and does not chain."
Review-Result: WARNING
More information about the test-report
mailing list