|WARNING| [v2] net/i40e: add IEEE1588 handling to AVX vector paths

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171705

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-19

# DPDK Patch Review

## ERRORS

None identified.

## WARNINGS

### Missing Release Notes Update
This patch adds a significant new feature (IEEE1588 support in AVX vector paths) that changes device capabilities. Per DPDK guidelines, significant changes require release notes updates.

**Fix:** Add an entry to `doc/guides/rel_notes/release_XX_YY.rst` documenting:
- IEEE1588/PTP timesync now supported in i40e AVX2 and AVX-512 vector Rx paths
- Vector path can now be used with IEEE1588 enabled on x86 platforms

### Missing Test Coverage
New functionality should include tests or testpmd hooks. This patch enables a previously unsupported feature combination (vector Rx + IEEE1588) but provides no way to verify it works correctly.

**Fix:** Add a functional test or document how to test the combination in `app/test-pmd` commands or add a note in the commit message describing manual testing performed.

## INFO

### Code Quality Observation
The patch adds 120+ lines of near-identical code to two separate files (`i40e_rxtx_vec_avx2.c` and `i40e_rxtx_vec_avx512.c`). While this duplication is consistent with the existing structure of these files (the FDIR code above it follows the same pattern), it creates a maintenance burden.

Not a requirement for this patch, but future refactoring could extract common logic into a shared macro or inline function in a header.

### Architecture-Specific Restriction
The condition check in `i40e_rxtx_vec_common.h` now allows IEEE1588 on `RTE_ARCH_X86` only. The comment correctly explains this is because only AVX2/AVX512 paths support it. This is appropriate given the scope of the patch, but worth noting that ARM NEON paths would also need updates to fully enable IEEE1588 in vector mode across all architectures.

Review-Result: WARNING