|WARNING| [v1,1/1] net/ice: remove obsolete shared counter support

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171677

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-19

# DPDK Patch Review

## Errors

None identified.

## Warnings

### Release Notes Missing

**Location:** No update to `doc/guides/rel_notes/release_*.rst`

The patch removes public-facing functionality (shared counter support) from the ice PMD. While the removed code paths were unreachable, this is a user-visible behavior change that should be documented in the release notes under a "Removed Items" or "API Changes" section.

**Suggested fix:**
Add an entry to the current release notes documenting that ice PMD no longer contains dead code for shared counter support (removed in ethdev API previously).

## Info

### Function Signature Simplification

**Location:** `ice_fdir_counter_alloc()` at line 332

The function now takes only one parameter (`struct ice_pf *pf`). The two removed parameters (`shared` and `id`) were only used for the shared-counter lookup path that is being deleted. This simplification is correct and improves the API.

### Removed Unreachable Code

The patch correctly identifies and removes dead code paths:
- `ice_fdir_counter_shared_search()` was only called when `shared` was true
- The `shared` parameter to `ice_fdir_counter_alloc()` was always 0 in the sole callsite
- Reference counting (`ref_cnt`) was only needed for shared counters

The cleanup is thorough and removes all vestiges of the shared counter infrastructure.

### Counter Release Logic Simplified

**Location:** `ice_fdir_counter_free()` at line 369

The function previously decremented `ref_cnt` and only freed when it reached zero. Since counters are no longer shared (ref_cnt always 1), the decrement-and-test is replaced with unconditional free. This is correct.

Review-Result: WARNING