|SUCCESS| [v6] dts: add ipgre test suite

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171716

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-19

# DPDK Patch Review

## ERRORS

None

## WARNINGS

### 1. Missing `RTE_EXPORT_*` annotation for new public API function

**File:** `dts/api/testpmd/__init__.py`  
**Line:** `def set_csum_parse_tunnel(self, port: int, on: bool, verify: bool = True) -> None:`

The new public function `set_csum_parse_tunnel()` is added to the TestPmd API but lacks an `RTE_EXPORT_*` annotation in the corresponding C implementation file (if this wraps a C function). However, reviewing the context more carefully, this appears to be Python-only code in the DTS (test framework), not a DPDK library function that would require C symbol export macros.

**Correction:** This is Python test framework code, not C library code. No export annotation needed. This item should be omitted.

### 2. New API requires release notes

**File:** `dts/api/testpmd/__init__.py`  
**Line:** New function `set_csum_parse_tunnel()`

The patch adds a new public API function to the testpmd wrapper but does not include corresponding release notes updates in `doc/guides/rel_notes/`. However, upon review, this is part of the DTS test framework rather than the core DPDK API exposed to applications, and the guidelines specify that internal API and helper functions (not exported to applications) do not require release notes.

**Correction:** DTS framework functions are not part of the public DPDK API exported to applications. Release notes are not required for test framework additions. This item should be omitted.

### 3. RST documentation could use definition list format

**File:** `doc/api/dts/tests.TestSuite_ip_gre.rst`

The documentation file is minimal and does not contain any lists that would benefit from definition list formatting. The automodule directive will generate the actual documentation from docstrings. No improvement needed here.

**Correction:** No lists present to convert. This item should be omitted.

## INFO

### 1. Test suite structure follows DTS patterns correctly

The new test suite follows established DTS patterns for test organization, packet crafting, and verification. The use of `@func_test` decorator, capability requirements via `@requires_nic_capability`, and interaction with TestPmd through the wrapper API are all consistent with existing test suites.

### 2. Good use of bool parameters with explicit comparison

The `set_csum_parse_tunnel()` function correctly uses `bool` type for the `on` parameter and performs explicit comparison in the verification logic, following DPDK coding standards.

### 3. Comprehensive test coverage

The test suite provides good coverage of GRE tunneling scenarios:
- IPv4 outer with IPv4 inner
- IPv6 outer with IPv4 inner  
- IPv6 outer with IPv6 inner
- Checksum offload verification
- VLAN-tagged variants

Review-Result: CLEAN