|SUCCESS| [v2] dts: remove crypto test type

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171719

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-19

# DPDK Patch Review

## ERRORS

None

## WARNINGS

None

## INFO

**File: dts/framework/test_run.py**

Line 367: Empty list initialization when no ports exist

```python
testrun_nic_info: list[dict[str, str]] = []
if ctx.topology.sut_ports:
    testrun_nic_info = self.test_run.ctx.sut_node.main_session.get_nic_info()
```

This pattern is correct. The conditional assignment ensures NIC info is only collected when ports exist, and an empty list is written to JSON when there are no ports. This addresses the issue mentioned in the commit message about writing an empty JSON file as a placeholder in no-link mode.

**File: dts/framework/testbed_model/topology.py**

Line 147-148: Conditional devbind script preparation

```python
if self.type is not LinkTopology.NO_LINK or get_ctx().sut_node.cryptodevs:
    self._prepare_devbind_script()
```

The logic prepares the devbind script when either (1) a link topology exists, or (2) cryptodevs are present. This correctly handles the no-link case with crypto devices, ensuring the devbind script is available when needed for crypto device binding even without network ports.

**Overall Assessment**

The patch correctly removes the `crypto` test type and repurposes crypto tests as performance tests. The changes properly handle the no-link topology case by:
- Only collecting NIC info when ports exist
- Preparing devbind script when crypto devices are present, even in no-link mode
- Writing an empty JSON file when no NIC info is available

The mechanical substitution of `@crypto_test` to `@perf_test` decorators and removal of `TestCaseType.CRYPTO` enum value and related filtering logic is consistent throughout.

Review-Result: CLEAN