|SUCCESS| stack: fix pile GCC memcpy warnings
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Tue Oct 20 12:19:30 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171733
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-20
# DPDK Patch Review
## Errors
None identified.
## Warnings
None identified.
## Info
### 1. Comment style - split long line
The comments explaining the GCC diagnostic pragmas exceed 100 characters and do not follow the multi-line comment format preferred in DPDK:
**Location:** lib/stack/rte_stack_pile.h:160-162, 289-291
**Current:**
```c
/*
* On architectures where rte_memcpy() is defined as memcpy(),
* although GCC knows that this code path is not taken when the source's size is smaller than
* RTE_STACK_PILE_BULK_SIZE, it still warns about memcpy() source overread.
* So we disable the compiler warning for this memcpy() instance.
*/
```
**Suggested:**
```c
/*
* On architectures where rte_memcpy() is defined as memcpy(),
* although GCC knows that this code path is not taken when the
* source's size is smaller than RTE_STACK_PILE_BULK_SIZE, it still
* warns about memcpy() source overread.
* So we disable the compiler warning for this memcpy() instance.
*/
```
The same applies to lines 289-291 for the destination overflow comment.
### 2. Commit message note format
The "NB:" and "PS:" sections in the commit message are informal. While not incorrect, DPDK commit messages typically use standard paragraphs or bullet points for additional context.
**Current:**
```
NB:
It has not been investigated which GCC versions are affected.
...
PS:
The alternative was to obfuscate the code...
```
**Suggested:** Integrate these as standard paragraphs without the "NB:" and "PS:" labels.
### 3. Commit message line about backporting
The line "The pile was introduce with this DPDK release, so no need to backport." should be removed or placed after the "---" separator (after Signed-off-by) as it's procedural information not part of the permanent commit message.
Review-Result: CLEAN
More information about the test-report
mailing list