|SUCCESS| [3/3] pcapng: add user-supplied timestamp support

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171782

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-20

# DPDK Patch Review

## PATCH 1/3: eal: add function to convert TSC to epoch time

### Errors

None.

### Warnings

None.

### Info

**lib/eal/common/eal_common_timer.c:60 - Hardening: Unsigned subtraction when `tsc < eal_tsc_base`**

```c
if (unlikely(tsc < eal_tsc_base))
    return eal_epoch_ns - cycles_to_ns(eal_tsc_base - tsc);
```

The comment states "handle both directions on an unsigned magnitude" and the subtraction `eal_tsc_base - tsc` is correct when `tsc < eal_tsc_base` (the condition just checked). The result of `cycles_to_ns()` is then subtracted from `eal_epoch_ns`. This requires that `cycles_to_ns(eal_tsc_base - tsc) <= eal_epoch_ns` or the unsigned subtraction wraps. For TSC values sampled shortly before `eal_tsc_base`, this is safe. For TSC values sampled long before (e.g., zero, or a very early TSC reading), the result wraps and is nonsensical. This is acceptable API behavior (garbage in, garbage out), but worth noting for robustness.

---

## PATCH 2/3: pcapng: use EAL TSC to epoch conversion

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 3/3: pcapng: add user-supplied timestamp support

### Errors

None.

### Warnings

None.

### Info

**lib/pcapng/rte_pcapng.c:670 - Check: Bit 63 flag comment and year 2262**

```c
/* Bit 63 is reserved to mark a TSC, see rte_pcapng_copy(). */
if (unlikely(timestamp & PCAPNG_TSC_FLAG)) {
    rte_errno = EINVAL;
    return NULL;
}
```

The rejection of timestamps with bit 63 set is correct. The comment in `rte_pcapng.h` states "epoch time in nanoseconds sets it only in the year 2262", which is accurate: `2^63` nanoseconds is approximately 292 years from 1970, reaching year 2262. This is well-documented and the check is appropriate.

**app/test/test_pcapng.c:753 - Test: Timestamp validation coverage**

```c
mc = rte_pcapng_copy_ts(port_id, 0, &mbfs.mb[0], mp,
                        rte_pktmbuf_pkt_len(&mbfs.mb[0]),
                        RTE_PCAPNG_DIRECTION_IN, NULL,
                        UINT64_C(1) << 63);
if (mc != NULL || rte_errno != EINVAL) {
    printf("rte_pcapng_copy_ts accepted a timestamp with bit 63 set\n");
    rte_pktmbuf_free(mc);
    goto fail;
}
```

The test correctly verifies that `rte_pcapng_copy_ts()` rejects a timestamp with bit 63 set and sets `rte_errno` to `EINVAL`. Good test coverage for the documented constraint.

---

## Summary

All three patches are correct. No errors or warnings. The patches introduce a new EAL API for TSC-to-epoch conversion, refactor pcapng to use it, and add user-supplied timestamp support to pcapng. The code is well-structured, documented, and tested. Release notes are appropriately updated. The API tags (`__rte_experimental`, `RTE_EXPORT_EXPERIMENTAL_SYMBOL`) are correctly applied.

Review-Result: CLEAN