|SUCCESS| [v1,2/2] net/ice: rename flow metadata parameter to rule

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171793

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-21

# DPDK Patch Review

## Patch 1/2: net/ice: remove unused flow handle from engines

### ERRORS
None.

### WARNINGS
None.

### INFO
This patch removes an unused parameter (`struct rte_flow *flow`) from engine create callbacks across the ice PMD. The parameter was marked `__rte_unused` in all four implementations (ACL, FDIR, hash, switch) and is no longer needed after the generic flow layer was changed to assign `flow->rule` itself.

The change is clean: it updates the callback typedef, all declarations, all implementations, and the single call site in `ice_generic_flow.c`.

---

## Patch 2/2: net/ice: rename flow metadata parameter to rule

### ERRORS
None.

### WARNINGS
None.

### INFO
This patch is a pure rename: `meta` parameters and related local variables are renamed to `rule` to reflect that parsers now return the final engine-specific rule object rather than temporary metadata. The rename spans engine callbacks (`create`, `free`), parser callbacks (`parse_pattern_action`), and internal call sites.

The change is entirely mechanical and does not alter any logic. It improves code clarity by aligning variable names with their actual role as persistent rule objects stored in `flow->rule`.

One minor inconsistency in `ice_acl_filter.c` is that a local variable `struct acl_rule *acl_rule` is introduced to avoid shadowing the parameter name `rule`, but this is correct and intentional disambiguation.

---

# Summary

Both patches are refactoring-only: they remove a dead parameter and rename another to improve clarity. No functional changes are introduced. The patches apply cleanly to the ice PMD's generic flow infrastructure.

No correctness bugs, style violations, or guideline issues were identified.

Review-Result: CLEAN