|SUCCESS| net/mlx5: fix mini CQE compression format log
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Wed Oct 21 21:37:47 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171821
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-21
# DPDK Patch Review
## ERRORS
None identified.
## WARNINGS
None identified.
## INFO
**Improved diagnostic logging**
The patch adds the Rx queue index to the debug log message and clarifies which mini CQE compression format is actually in use versus what was configured. The existing log only showed the configured format (`priv->config.cqe_comp_fmt`), but the patch now logs both the effective format in use for this queue (`rxq_data->mcqe_format`) and the configured format. This is a useful diagnostic improvement when debugging CQE compression behavior across multiple queues.
The format specifier change from `%d` to `%u` for `priv->config.cqe_comp_fmt` is correct since configuration values are typically unsigned.
**Minor wording suggestion**
The log message could be slightly more grammatical with a verb:
```c
"Port %u Rx queue %u: CQE compression enabled, format %u (configured: %u)"
```
However, the existing wording is clear and consistent with DPDK's terse logging style, so this is optional.
---
Review-Result: CLEAN
More information about the test-report
mailing list