|WARNING| net/mlx5: log Rx queue CQ number

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Thu Oct 22 02:40:59 CEST 2026


Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171822

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-22

# DPDK Patch Review

## Summary

This patch adds debug logging to output the CQ (Completion Queue) number for each Rx queue during port start in the mlx5 PMD. The change is minimal and focused.

## Errors

None.

## Warnings

**1. Missing local variable declaration**

The code references `port_id` which is not defined in the current function scope.
Looking at the surrounding code in `mlx5_rxq_create_devx_cq_resources()`, there is no `port_id` variable declared or passed as a parameter.

```c
+	DRV_LOG(DEBUG, "Port %u Rx queue %u cqn=%u", port_id, rxq->idx, rxq_data->cqn);
```

The `port_id` should either be:
- Obtained from `rxq->priv->dev_data->port_id` (typical pattern in mlx5 PMD), or
- Added as a function parameter, or
- Removed from the log message if not essential

**Suggested fix:**
```c
+	DRV_LOG(DEBUG, "Port %u Rx queue %u cqn=%u",
+		rxq->priv->dev_data->port_id, rxq->idx, rxq_data->cqn);
```

or if `dev_data` is not directly accessible through the `rxq` structure:
```c
+	DRV_LOG(DEBUG, "Rx queue %u cqn=%u", rxq->idx, rxq_data->cqn);
```

**2. Missing release notes update**

While this is a debug-only change, it adds new debug output that could be useful for users debugging with FW tools. However, this is borderline - debug logging changes typically don't require release notes unless they expose significant new debugging capabilities.

Given that the commit message specifically states this is "to allow easier debugging with FW tools", documenting this in release notes under a "Debug/Diagnostics" section might be appropriate, though not strictly required for debug-level logging.

## Info

None.

---

**Note:** The primary issue is the undefined `port_id` variable which will cause a compilation error. This must be fixed before the patch can be accepted.

Review-Result: WARNING


More information about the test-report mailing list