|SUCCESS| [v9, 16/16] net/txgbe: respect manual link-down on Amber-Lite

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171845

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-22

# DPDK Patch Review

## Patch 01/16: net/txgbe: fix failure to configure 10G on dual-speed DAC

### Errors

None.

### Warnings

None.

### Info

- **Pre-existing code** (drivers/net/txgbe/base/txgbe_aml40.c:173-183):
  The setup_phy_link_aml40() function performs a complex multi-step PHY initialization sequence after the speed selection logic. While the speed handling is fixed by this patch, the initialization sequence itself could fail partway through (e.g., at line 205 `txgbe_set_link_to_amlite()` timeout, lines 191-201 post-selection logic). Each failure path should be audited to ensure cleanup is complete and the PHY is left in a well-defined state. This is pre-existing, not introduced by this patch.

---

## Patch 02/16: net/txgbe: use the requested speed in E56 AN setup

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 03/16: net/txgbe: fix e56 PHY configuration error

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 04/16: net/txgbe: fix incorrect link state in 10G forced mode

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 05/16: net/txgbe: do not force reconfig on link retry

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 06/16: net/txgbe: set i2c sda hold time

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 07/16: net/txgbe: fix link speed display info for 10G mode

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 08/16: net/txgbe: remove stale outer UDP checksum offload flag

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 09/16: net/txgbe: fix SFP hot-plug when auto-negotiation is on

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 10/16: net/txgbe: fix DAC hot-plug on 40G NIC with auto-negotiation

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 11/16: net/txgbe: fix 40G FFE tuning applied to first lane only

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 12/16: net/txgbe: add pre2 FFE tap and backplane capability devargs

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 13/16: net/txgbe: add devarg to turn off Tx laser for 40G NIC

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 14/16: net/txgbe: fix CR/KR link training and recovery

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 15/16: net/txgbe: align link capabilities and DAC classification

### Errors

None.

### Warnings

None.

### Info

None.

---

## Patch 16/16: net/txgbe: respect manual link-down on Amber-Lite

### Errors

None.

### Warnings

None.

### Info

None.

---

## Summary

This series addresses a comprehensive set of link configuration and PHY management issues in the txgbe driver, particularly for the Amber-Lite 25G and 40G NICs. The patches fix:

1. **Link configuration**: 10G configuration on dual-speed DAC cables, speed advertisement in AN base page, link state reporting
2. **PHY tuning**: RXS ring equalizer/tap configuration bit field errors, FFE defaults and per-lane replication for 40G
3. **Hot-plug**: SFP detection alarm and AN73 watchdog interaction, module removal/insertion handling, 40G GPIO polling for insertion (no interrupt delivered)
4. **AN73 and link training**: Page exchange timeout and retry, FSM completion polling, FFE init mode and calibration ordering
5. **Administrative link control**: Respect manual link-down, laser disable on link-down (opt-in via devarg)
6. **Devargs**: Add `ffe_pre2`, `bp_capa`, and `laser_off` for fine-tuning and backplane capability selection

All patches apply cleanly, follow DPDK coding standards, and include appropriate Fixes tags and stable at dpdk.org CC. Release notes and documentation are updated. No correctness bugs were identified in the review.

Review-Result: CLEAN