|SUCCESS| [1/1] log: add name query functions

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171873

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-22

# DPDK Patch Review

## Errors

None identified.

## Warnings

None identified.

## Info

### 1. Test Assertions - Explicit Comparison Style

**Location:** `app/test/test_logs.c:113-115`

```c
TEST_ASSERT(strcmp(rte_log_get_level_name(RTE_LOG_ERR), "error") == 0,
	"invalid name for error log level\n");
```

DPDK coding style prefers explicit comparison against 0 for integer return values. The `strcmp()` calls are correctly using `== 0` rather than `!strcmp()`, which is good. However, for consistency with DPDK style, consider that the boolean result could be written more explicitly, though the current form is acceptable and clear.

### 2. API Design - String Ownership Documentation

**Location:** `lib/log/rte_log.h:135, 149`

The Doxygen comments correctly document string ownership:
- `rte_log_get_level_name()`: "owned by DPDK and must not be modified or freed"
- `rte_log_get_type_name()`: "owned by DPDK, remains valid for the lifetime of the process, and must not be modified or freed"

This is exemplary API documentation. The distinction between the two (level names are compile-time constants vs type names that persist for process lifetime) is clear and appropriate.

### 3. Implementation - Direct Return of Internal Pointers

**Location:** `lib/log/log.c:143`

```c
return rte_logs.dynamic_types[type].name;
```

The function returns a direct pointer to the internal `name` field in the dynamic types array. This is safe because:
- The Doxygen explicitly documents the lifetime ("remains valid for the lifetime of the process")
- Registered log types are never unregistered in the current DPDK model
- The caller is explicitly warned not to modify or free the string

This is an acceptable design choice for a read-only query API.

### 4. Code Quality - Bounds Check

**Location:** `lib/log/log.c:139-140`

```c
if (type >= rte_logs.dynamic_types_len)
	return NULL;
```

Good defensive programming - validates the type index before accessing the array. The test coverage in `app/test/test_logs.c:120-121` verifies this behavior with `UINT32_MAX`.

---

## Summary

This patch introduces well-designed experimental API for querying log level and type names. The implementation is straightforward and correct, with:

- Proper experimental API marking and symbol exports
- Comprehensive Doxygen documentation including string ownership semantics
- Appropriate unit test coverage including boundary cases
- Documentation updates in both the programming guide and release notes
- Defensive bounds checking in the type name lookup

The code follows DPDK conventions and adds useful introspection capabilities without introducing correctness issues or resource management problems.

Review-Result: CLEAN