|SUCCESS| dts: update cryptography dependency to avoid test discovery failure on ppc
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Oct 23 00:31:34 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171874
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-22
# DPDK Patch Review
## Summary
This patch updates the `cryptography` dependency from version 44.0.0 to 50.0.2 to resolve a test discovery failure on ppc64le. The issue arises because cryptography 44.0.0, when built from source on ppc64le, includes a top-level "tests" package that shadows the DTS namespace package, preventing test suite discovery.
## Errors
None identified.
## Warnings
None identified.
## Info
**Dependency update scope:** The patch updates `cryptography` from 44.0.0 to 50.0.2 and `cffi` from 1.17.1 to 2.1.1. The cffi update is a dependency change driven by the cryptography requirement (`cffi >= 2.0.0`). Both updates appear in `poetry.lock` only, indicating they were generated by Poetry's dependency resolver.
**Platform-specific build artifact:** The commit message notes that the "tests" package appears only in the ppc64le source-built wheel (44.0.0), not in x86 prebuilt wheels. This is a build-time artifact issue rather than a code defect in DPDK. The cryptography project has since addressed this in newer versions.
**Version jump rationale:** The commit message acknowledges the large version jump (44.0.0 - 50.0.2, spanning 6 major releases) and offers to investigate the minimum version that resolves the issue if this proves problematic. For a test-only dependency, this is reasonable, but verifying compatibility with the oldest supported Python version (appears to be 3.9 based on the lock file) would be prudent.
**Lock file Poetry version change:** The lock file header indicates Poetry 2.3.2 - 2.5.1. This is expected when regenerating the lock with a newer Poetry installation and does not affect the runtime dependency set.
**No release notes required:** This change is test infrastructure only (DTS framework dependency) and does not affect the DPDK library, drivers, or public API. Per the guidelines, test-only changes do not require release notes.
Review-Result: CLEAN
More information about the test-report
mailing list