|WARNING| pw171920 [PATCH v4-S3 01/65] net/dpaa2: refactor and optimize Rx parser result decode

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/171920

_coding style issues_


WARNING:TYPO_SPELLING: 'fle' may be misspelled - perhaps 'file'?
#1065: FILE: drivers/net/dpaa2/dpaa2_parse_dump.h:241:
+	if (fas->fle)
 	         ^^^

WARNING:TYPO_SPELLING: 'fle' may be misspelled - perhaps 'file'?
#1389: FILE: drivers/net/dpaa2/dpaa2_parser_decode.h:144:
+	uint32_t fle:1;
 	         ^^^

CHECK:SPACING: No space is necessary after a cast
#1886: FILE: drivers/net/dpaa2/dpaa2_parser_decode.h:641:
+	return (DPAA2_BIT_LAST_OFFSET(union dpaa2_sp_fafe_parse_8b) - idx) +

CHECK:SPACING: No space is necessary after a cast
#1900: FILE: drivers/net/dpaa2/dpaa2_parser_decode.h:655:
+	return (DPAA2_BIT_LAST_OFFSET(union dpaa2_faf_l_parse_32b) - idx) +

CHECK:SPACING: No space is necessary after a cast
#1914: FILE: drivers/net/dpaa2/dpaa2_parser_decode.h:669:
+	return (DPAA2_BIT_LAST_OFFSET(union dpaa2_faf_h_parse_64b) - idx) +

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2035: FILE: drivers/net/dpaa2/dpaa2_parser_decode.h:790:
+#define ECPRI(type) (void)(type)

BUT SEE:

   do {} while (0) advice is over-stated in a few situations:

   The more obvious case is macros, like MODULE_PARM_DESC, invoked at
   file-scope, where C disallows code (it must be in functions).  See
   $exceptions if you have one to add by name.

   More troublesome is declarative macros used at top of new scope,
   like DECLARE_PER_CPU.  These might just compile with a do-while-0
   wrapper, but would be incorrect.  Most of these are handled by
   detecting struct,union,etc declaration primitives in $exceptions.

   Theres also macros called inside an if (block), which "return" an
   expression.  These cannot do-while, and need a ({}) wrapper.

   Enjoy this qualification while we work to improve our heuristics.

CHECK:CAMELCASE: Avoid CamelCase: <ROCEv2>
#2036: FILE: drivers/net/dpaa2/dpaa2_parser_decode.h:791:
+#define ROCEv2(type) (void)(type)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2036: FILE: drivers/net/dpaa2/dpaa2_parser_decode.h:791:
+#define ROCEv2(type) (void)(type)

BUT SEE:

   do {} while (0) advice is over-stated in a few situations:

   The more obvious case is macros, like MODULE_PARM_DESC, invoked at
   file-scope, where C disallows code (it must be in functions).  See
   $exceptions if you have one to add by name.

   More troublesome is declarative macros used at top of new scope,
   like DECLARE_PER_CPU.  These might just compile with a do-while-0
   wrapper, but would be incorrect.  Most of these are handled by
   detecting struct,union,etc declaration primitives in $exceptions.

   Theres also macros called inside an if (block), which "return" an
   expression.  These cannot do-while, and need a ({}) wrapper.

   Enjoy this qualification while we work to improve our heuristics.

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#2640: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:154:
+		DPAA2_PMD_DP_DEBUG("pkt timestamp: 0x%" PRIx64 "",

total: 2 errors, 2 warnings, 5 checks, 2850 lines checked
Warning in drivers/net/dpaa2/dpaa2_rxtx.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t