|WARNING| [v4,8/8] interrupts: warn on leaked event FDs
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Oct 23 17:49:29 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171992
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-23
# DPDK Patch Review
## PATCH 1/8: interrupts: fix size of duplicated instance
### Errors
None.
### Warnings
None.
### Info
None.
---
## PATCH 2/8: interrupts: fix event arrays copy on instance duplication
### Errors
**Integer multiply without widening cast**
```c
memcpy(intr_handle->efds, src->efds, src->nb_intr * sizeof(*src->efds));
memcpy(intr_handle->elist, src->elist, src->nb_intr * sizeof(*src->elist));
```
If `src->nb_intr` is `uint32_t` (or narrower) and `sizeof(*src->efds)` is computed at 32-bit width, the multiplication can overflow before widening to `size_t` for the third argument to `memcpy()`. This would cause a truncated byte count and an incomplete copy.
**Suggested fix:** Cast `src->nb_intr` to `size_t` before the multiply:
```c
memcpy(intr_handle->efds, src->efds, (size_t)src->nb_intr * sizeof(*src->efds));
memcpy(intr_handle->elist, src->elist, (size_t)src->nb_intr * sizeof(*src->elist));
```
---
## PATCH 3/8: eal/linux: fix closing of event FDs not owned by EAL
### Errors
None.
### Warnings
None.
### Info
None.
---
## PATCH 4/8: eal/linux: fix eventfd leaks when enabling interrupts
### Errors
None.
### Warnings
None.
### Info
None.
---
## PATCH 5/8: eal/linux: fix leaked FD warnings for interrupt sources
### Errors
None.
### Warnings
None.
### Info
None.
---
## PATCH 6/8: eal/freebsd: fix interrupt source handle leak
### Errors
None.
### Warnings
None.
### Info
None.
---
## PATCH 7/8: bus/pci: fix leaked device FD warning on VFIO unmap
### Errors
None.
### Warnings
None.
### Info
None.
---
## PATCH 8/8: interrupts: warn on leaked event FDs
### Errors
None.
### Warnings
None.
### Info
None.
---
Review-Result: ERROR
More information about the test-report
mailing list