|WARNING| [v4] examples/l3fwd: fix RFC 1812 checks

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172033

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-24

# DPDK Patch Review

## ERRORS

None.

## WARNINGS

### 1. Missing release notes update

**Location:** The patch fixes multiple bugs but does not include a release notes update.

**Issue:** Bug fixes that change behavior (especially those affecting examples that users may copy) should be documented in release notes. This patch fixes four separate bugs plus adds a new check, all affecting packet validation behavior.

**Suggested fix:** Add an entry to the current release notes file under a "Bug Fixes" or "Examples" section:

```rst
* **examples/l3fwd: Fixed RFC 1812 IPv4 validation.**

  * Corrected checksum validation to handle all four RTE_MBUF_F_RX_IP_CKSUM_* values
  * Fixed checksum calculation to preserve the checksum field in the packet
  * Fixed Link Layer length check to exclude Ethernet header
  * Fixed IP header length validation to account for IP options
  * Added recommended check for Link Layer length vs IP total length
```

## INFO

### 1. Checksum calculation improvement (correctness verification)

**Location:** `examples/l3fwd/l3fwd.h`, lines 175-178

The new checksum validation correctly uses `rte_ipv4_cksum(pkt) != 0` instead of the previous pattern that modified the packet. The function `rte_ipv4_cksum()` computes the checksum treating the existing checksum field as zero internally, so the result is zero if and only if the checksum is valid. This is the correct approach and avoids the bug where the packet's checksum field was zeroed on success.

### 2. All four checksum offload states now handled

**Location:** `examples/l3fwd/l3fwd.h`, lines 173-186

The switch statement now explicitly handles all four values of `RTE_MBUF_F_RX_IP_CKSUM_MASK`:
- `UNKNOWN`: software validation (the common case)
- `GOOD`: hardware validated, accept
- `BAD`: hardware detected error, reject
- `NONE`: integrity known good but checksum field unset, accept

This is more robust than the previous code which only handled `NONE` and implicitly accepted everything else.

### 3. IP header length correctly used

**Location:** `examples/l3fwd/l3fwd.h`, line 207

The check now uses `rte_ipv4_hdr_len(pkt)` instead of `sizeof(struct rte_ipv4_hdr)`, which correctly accounts for IP options. The RFC 1812 requirement is that total length >= header length, where header length is the IHL field times 4 bytes.

### 4. Layer 2 overhead correctly subtracted

**Location:** `examples/l3fwd/l3fwd_em.h` line 24, `examples/l3fwd/l3fwd_lpm.h` line 26

The callers now pass `m->pkt_len - sizeof(struct rte_ether_hdr)` as the link_len, which correctly represents the IP datagram length. The validation function compares this against the IP total_length field, which is defined as the length of the IP datagram (IP header + data), not including Layer 2 framing.

### 5. Additional RFC 1812 check added

**Location:** `examples/l3fwd/l3fwd.h`, lines 210-216

The new check verifies link_len >= IP total_length, which is the SHOULD-level recommendation from RFC 1812 section 5.2.2. This catches cases where the Link Layer reports a shorter frame than the IP header claims, which could indicate truncation or corruption.

Review-Result: WARNING