|WARNING| net/ixgbe: remove unreachable WFQ weight mode check

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172057

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-24

# DPDK Patch Review

## Analysis

This patch removes dead code in `drivers/net/intel/ixgbe/ixgbe_tm.c`. The author claims that after an earlier check rejects non-NULL `nonleaf.wfq_weight_mode` with "WFQ not supported", a later check on the same pointer is unreachable.

Reading the code flow in `ixgbe_node_param_check()`:

1. Earlier in the function (lines not shown in diff, but confirmed by the logic described), `params->nonleaf.wfq_weight_mode` is checked and if non-NULL, the function returns with error "WFQ not supported"
2. The removed code checks `params->nonleaf.wfq_weight_mode &&` again - this would only execute if the pointer is non-NULL
3. Since any non-NULL case already returned earlier, this branch is indeed unreachable

The patch correctly identifies and removes dead code. The logic is sound.

## Findings

### ERRORS

None.

### WARNINGS

**1. Missing release notes entry**

This patch modifies driver code by removing a dead code path. While it has no functional impact, it's a code change to a driver and should be documented in the release notes to provide visibility of the cleanup.

**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_26_XX.rst` (where XX is the current release number) under a "Bug Fixes" or "Code Cleanup" section:

```rst
* **net/ixgbe: Removed unreachable code in traffic manager.**

  Removed unreachable WFQ weight mode check that could never be executed
  due to earlier validation.
```

### INFO

None.

---

Review-Result: WARNING