|SUCCESS| [2/2] vdpa/mlx5: fix RQT attributes memory leak

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172062

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-25

# DPDK Patch Review

## PATCH 1/2: vdpa/mlx5: fix RSS flow leak on steering update failure

### ERRORS

None.

### WARNINGS

None.

### INFO

None.

---

## PATCH 2/2: vdpa/mlx5: fix RQT attributes memory leak

### ERRORS

None.

### WARNINGS

None.

### INFO

None.

---

# Summary

Both patches address resource leaks in error paths:

**Patch 1/2** fixes a leak of RSS steering objects (matcher, TIR, TIR action, flow) when `mlx5_vdpa_rss_flows_create()` fails. The patch adds cleanup by calling `mlx5_vdpa_rss_flows_destroy()` on the error path in `mlx5_vdpa_steer_update()`. Since `mlx5_vdpa_rss_flows_destroy()` checks each object for NULL, this is safe even when called again by `mlx5_vdpa_steer_unset()` on the `steer_setup()` error path.

**Patch 2/2** fixes a leak of RQT attributes allocated with `rte_zmalloc()` when the early-return path (`k == 0`) is taken in `mlx5_vdpa_rqt_prepare()`. The patch adds `rte_free(attr)` before the return.

Both patches correctly identify and fix resource leaks on error paths. The code changes are minimal, targeted, and follow the existing error-handling patterns. The commit messages clearly explain the bug, the impact, and the fix.

Review-Result: CLEAN