|SUCCESS| net/mlx5: fix LSC interrupt device flags
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Mon Oct 26 17:36:14 CET 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172086
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-26
# Review of DPDK Patch: net/mlx5: fix LSC interrupt device flags
## ERRORS
None identified.
## WARNINGS
None identified.
## INFO
**Documentation follows code change correctly.**
The patch adds a row to the feature matrix in `doc/guides/nics/mlx5.rst` documenting that Link State Change interrupts are supported on Linux (marked with `X`) but not on Windows (no mark). This correctly reflects the code change where `MLX5_NET_INTR_LSC_SUPPORTED` is defined as `(1)` on Linux and `(0)` on Windows.
**Macro naming follows DPDK convention.**
The new platform-specific macro `MLX5_NET_INTR_LSC_SUPPORTED` follows the existing pattern in mlx5 OS abstraction headers where platform differences are expressed as preprocessor definitions in `linux/mlx5_os.h` and `windows/mlx5_os.h`.
**Correctness of the fix.**
The patch correctly addresses a false-positive device capability report on Windows. Prior to this change, `intr_lsc = 1` unconditionally set the LSC interrupt flag on both platforms. With this change, Windows correctly reports LSC as unsupported via `MLX5_NET_INTR_LSC_SUPPORTED (0)`, while Linux continues to report it as supported via `MLX5_NET_INTR_LSC_SUPPORTED (1)`.
Review-Result: CLEAN
More information about the test-report
mailing list