|WARNING| [v3] dts: remove crypto test type

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Mon Oct 26 21:42:01 CET 2026


Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172125

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-26

# DPDK Patch Review

## ERRORS

None identified.

## WARNINGS

**dts/framework/testbed_model/topology.py:**

The `get_ctx()` import inside the `setup()` method is unusual.
```python
def setup(self) -> None:
    """Setup the topology.

    Binds all the ports to the right kernel driver to retrieve MAC addresses and logical names.
    """
    from framework.context import get_ctx

    if self.type is not LinkTopology.NO_LINK or get_ctx().sut_node.cryptodevs:
        self._prepare_devbind_script()
```

Imports are normally placed at the top of the file.
An import inside a function is a code smell that often indicates a circular dependency issue.
If `framework.context` cannot be imported at module level due to import cycles,
that design problem should be addressed rather than worked around.
If the import *can* be at module level, it should be moved there for clarity and consistency.

## INFO

None.

---

Review-Result: WARNING


More information about the test-report mailing list