|SUCCESS| [v3] dts: remove crypto test type
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Mon Oct 26 21:47:44 CET 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172125
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-26
# DPDK Patch Review
## ERRORS
None identified.
## WARNINGS
None identified.
## INFO
### Documentation - RST example config formatting
The example config file (`dts/configurations/test_run.example.yaml`) is not `.rst` format, so the definition list suggestion does not apply here. YAML files have their own formatting rules. No issue.
### Pre-existing code observation
In `dts/framework/test_run.py`, the cryptodev binding logic at line 375 uses:
```python
if ctx.sut_node.cryptodevs and test_run.config.perf:
```
This changes the condition from `test_run.config.crypto` to `test_run.config.perf`, effectively making crypto device binding dependent on the performance test flag. This is the intended behavior per the commit message (crypto tests are now performance tests), but it means crypto device setup will occur whenever `perf: true` regardless of whether crypto tests are actually in the test suite. This is acceptable but worth noting.
The patch correctly removes the `crypto` test type infrastructure and relabels crypto tests as `perf_test`. The NIC info handling for no-link topology is improved with appropriate logging. All code changes are consistent with the stated goal of removing the crypto test type distinction.
Review-Result: CLEAN
More information about the test-report
mailing list