|WARNING| [v12, 17/17] net/txgbe: fix typo in the fiber support speed field

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172175

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-27

# DPDK Patch Review

## PATCH 01/17: net/txgbe: fix failure to configure 10G on dual-speed DAC

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 02/17: net/txgbe: use the requested speed in E56 AN setup

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 03/17: net/txgbe: fix E56 PHY configuration error

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 04/17: net/txgbe: fix incorrect link state in 10G forced mode

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 05/17: net/txgbe: do not force reconfig on link retry

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 06/17: net/txgbe: set i2c sda hold time

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 07/17: net/txgbe: fix link speed display info for 10G mode

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 08/17: net/txgbe: remove stale outer UDP checksum offload flag

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 09/17: net/txgbe: fix SFP hot-plug when auto-negotiation is on

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 10/17: net/txgbe: fix DAC hot-plug on AML40 with auto-negotiation

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 11/17: net/txgbe: fix 40G FFE tuning applied to first lane only

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 12/17: net/txgbe: add pre2 FFE tap and backplane capability devargs

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 13/17: net/txgbe: fix Tx laser left on at AML40 link down

### Errors

**drivers/net/txgbe/base/txgbe_hw.c:3278**
```c
} else if (hw->mac.acquire_swfw_sync(hw,
                    TXGBE_MNGSEM_SWPHY) == 0) {
    hw->phy.write_i2c_eeprom(hw,
        TXGBE_SFF_8636_TX_DISABLE,
        TXGBE_SFF_8636_TX_DISABLE_ALL_LANES);
    hw->mac.release_swfw_sync(hw,
                TXGBE_MNGSEM_SWPHY);
}
```
If `acquire_swfw_sync()` succeeds but `write_i2c_eeprom()` fails, the semaphore is released but the failure is not propagated. The caller continues as if the Tx disable succeeded, which could leave the transmitter in an unexpected state.

**drivers/net/txgbe/base/txgbe_hw.c:3316**
```c
if (!txgbe_is_dac_cable(hw) &&
    hw->phy.sfp_type != txgbe_sfp_type_unknown &&
    hw->phy.sfp_type != txgbe_sfp_type_not_present &&
    hw->mac.acquire_swfw_sync(hw, TXGBE_MNGSEM_SWPHY) == 0) {
    hw->phy.write_i2c_eeprom(hw,
        TXGBE_SFF_8636_TX_DISABLE, 0x0);
    hw->mac.release_swfw_sync(hw, TXGBE_MNGSEM_SWPHY);
}
```
Same issue: if `write_i2c_eeprom()` fails after `acquire_swfw_sync()` succeeds, the failure is not checked or logged, and the caller assumes Tx was enabled.

### Warnings

None.

### Info

None.

---

## PATCH 14/17: net/txgbe: fix CR/KR link training and recovery

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 15/17: net/txgbe: align link capabilities and DAC classification

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 16/17: net/txgbe: respect manual link-down on Amber-Lite

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 17/17: net/txgbe: fix typo in the fiber support speed field

### Errors

None.

### Warnings

None.

### Info

None.

---

## Summary

One patch (13/17) contains correctness bugs where I2C EEPROM write failures after successful semaphore acquisition are not checked. The other 16 patches are clean.

Review-Result: ERROR