|WARNING| bpf: fix index register for classic BPF indirect loads

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172185

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-27

Review of DPDK patch: bpf: fix index register for classic BPF indirect loads

## ERRORS

**Error path resource leak on conversion failure:**

The function `bpf_convert_filter()` allocates memory for `new_prog` via `rte_malloc()` but does not free it on several error paths. While this patch does not introduce new error paths, it is worth noting that the existing code has this issue. However, since this is pre-existing and not introduced by this patch, this is informational only.

## CORRECTNESS REVIEW

**Patch correctness:** The patch correctly addresses the reported bug. The indirect load instructions (`BPF_LD|BPF_IND|BPF_W`, `BPF_LD|BPF_IND|BPF_H`, `BPF_LD|BPF_IND|BPF_B`) were incorrectly sharing a case with arithmetic instructions. The arithmetic instructions use `BPF_SRC(code)` to determine the source register, but for load instructions, that bit is part of the size field. The fix correctly moves these cases to their own handler that explicitly sets `src_reg` to `BPF_REG_X`, matching the behavior of absolute loads which set it to 0.

**No new resource leaks introduced:** The patch only modifies case statement organization and does not introduce any new allocations, frees, or error paths.

**No use-after-free:** The patch does not introduce any memory access after free.

**No race conditions:** The patch modifies pure computational logic with no new shared state.

## STYLE REVIEW

**Code structure:** The code follows DPDK style with proper indentation and comment format.

**Comment quality:** The added comment `/* Indirect loads index the packet with X: A = P[X + k] */` clearly explains the purpose of the new case block, which is helpful context for the fix.

**Consistency:** The new case block follows the same pattern as the existing absolute loads case immediately above it.

## API AND DOCUMENTATION

**No API changes:** This is an internal bug fix with no API modifications.

**Release notes required:** Yes. This fixes a correctness bug in BPF filter conversion that causes wrong packet bytes to be read. The fix should be documented in the release notes under "Fixed Issues" for the BPF library.

**Stable backport:** Correctly marked with `Cc: stable at dpdk.org` since this fixes a bug introduced in commit 2eccf6afbea9.

## MISSING ITEMS

**Missing release notes update:** The patch does not include an update to `doc/guides/rel_notes/release_X_YY.rst` documenting this bug fix. This should be added.

Review-Result: WARNING