|SUCCESS| net/ice/base: fix E830 PHY timer command

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172228

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-28

# DPDK Patch Review

## ERRORS

None identified.

## WARNINGS

None identified.

## INFO

### Code Quality

**Unused function removal**: The patch removes `ice_ptp_port_cmd_e830()` which was attempting to write a PHY command via sideband queue but failing with firmware errors on E830. The removal is appropriate since E830's internal PHY follows the source timer command automatically and does not need separate port commands.

**Comment clarity**: The added comment "The internal PHY follows the source timer command" clearly explains why E830 returns early without issuing a port command.

### Testing Evidence

The patch includes comprehensive testing data showing:
- Before patch: all calls failed with -100 (ICE_ERR_AQ_ERROR)
- After patch: calls succeed with expected PHC adjustments
- Test deltas ranging from 0 to +-1000000 ns all work correctly

This demonstrates the fix addresses the reported issue where `rte_eth_timesync_adjust_time()` was failing on E830.

### Code Structure

The early return pattern (`return 0;`) for E830 in `ice_ptp_port_cmd()` is consistent with the existing code structure that handles different PHY models via switch statement. The approach is clean and maintains the function's existing error handling contract.

Review-Result: CLEAN