|WARNING| net/ice/base: fix E830 PHY timer command

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172228

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-28

# DPDK Patch Review

## Summary

This patch fixes E830 PHY timer command handling by removing an unused register write that was causing firmware errors. The fix addresses a PTP clock adjustment failure introduced in a previous commit.

---

## ERRORS

### 1. Missing release notes update

**Issue:** This patch fixes a significant functional bug (PTP clock adjustment failing) but does not update the release notes.

**Why it matters:** Release notes are required for important changes per AGENTS.md, and a fix that restores PTP functionality is user-visible.

**Fix:** Add an entry to `doc/guides/rel_notes/release_XX_XX.rst` (current release) under "Fixed Issues" describing the PTP adjustment failure and the fix.

Example:
```rst
* **net/ice: Fixed PTP clock adjustment on E830.**

  Fixed ``rte_eth_timesync_adjust_time()`` failing with error -100 on E830 devices.
  The PHY timer command was incorrectly being sent to firmware, which rejected it.
```

---

## WARNINGS

None identified.

---

## INFO

### 1. Consider testing coverage note

The commit message includes detailed test results showing the fix works across multiple delta values. This is excellent documentation. Consider whether a functional test could be added to prevent regression, though PTP hardware requirements may make this impractical for CI.

---

## FINAL CHECK

**Pass 1 (Correctness):** No resource leaks, use-after-free, or other correctness bugs identified. The patch removes code rather than adding risky paths.

**Pass 2 (Style/Process false positives):** No style items flagged that were later deemed acceptable.

**Pass 3 (Evidence):**
- Error #1 rests on the absence of release notes changes in the patch, which is verifiable from the diff.

The missing release notes is a process requirement violation that should be fixed.

Review-Result: ERROR