|SUCCESS| ethdev/telemetry: fix hide_zero parameter being reset

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172252

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-30

# DPDK Patch Review

## ERRORS

None.

## WARNINGS

None.

## INFO

None.

---

## Analysis

This patch fixes a logic bug in the ethdev telemetry registers command where the `hide_zero` parameter was being unconditionally reset to `false` after successful parsing, causing the user-supplied value to be silently ignored.

**What the patch does:**
- Removes the `hide_zero = false;` assignment from the `else` branch that executes after successful parsing
- The parsed `hide_zero` value is now correctly retained and passed to `eth_dev_get_port_regs()`

**Code correctness:**
- The fix is correct: the `else` branch only executes when parsing succeeds (`kvlist != NULL && filter_val valid && ret == 0`), so removing the reset allows the parsed value from `eth_dev_parse_hide_zero()` to be used
- No resource leaks: `rte_kvargs_free(kvlist)` is called on all paths
- Error handling is appropriate: malformed input triggers a log message and falls back to defaults

**Style compliance:**
- Follows DPDK style (brace removal for single statement in `else` branch is correct)
- No forbidden tokens
- Appropriate use of `__rte_unused` attribute

**Process compliance:**
- Correctly tagged with `Fixes:` and `Cc: stable at dpdk.org`
- Targets a bug fix appropriate for stable backport

The patch is a straightforward bug fix with no correctness issues, style violations, or process problems.

Review-Result: CLEAN