|SUCCESS| [v1,9/9] net/i40e: allow L2 and L3 only hash patterns

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172285

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-30

# DPDK Patch Review

## Patch 1/9: net/i40e: skip FDIR flow engine when FDIR is unavailable

**Errors:**

None identified.

**Warnings:**

None identified.

**Info:**

None.

---

## Patch 2/9: net/i40e: reject VLAN with tunnel items in FDIR flows

**Errors:**

None identified.

**Warnings:**

None identified.

**Info:**

None.

---

## Patch 3/9: net/i40e: move FDIR flow state out of the flow engine

**Errors:**

1. **Resource leak on error path** (`i40e_fdir.c:1016-1019`)
   ```c
   if (store->pool == NULL) {
       PMD_INIT_LOG(ERR, "Failed to create fdir flow pool: %s", rte_strerror(rte_errno));
       ret = -rte_errno;
       goto err;
   ```
   The `goto err` leads to `i40e_fdir_flow_store_free()` which calls `rte_hash_free(store->hash_table)`.
   However, if `rte_mempool_create()` fails, `store->hash_table` was successfully allocated on line 997 and is not NULL.
   The cleanup function will free it correctly, so this is not a leak.
   After re-checking: the error path is correct -- `i40e_fdir_flow_store_free()` is safe to call even if the pool allocation failed, because it uses `rte_mempool_free()` and `rte_hash_free()` which accept NULL.
   No issue here.

**Warnings:**

None identified.

**Info:**

None.

---

## Patch 4/9: net/i40e: fix FDIR ethertype match with other items

**Errors:**

None identified.

**Warnings:**

None identified.

**Info:**

None.

---

## Patch 5/9: net/i40e: validate IPv4 fragment offset without range

**Errors:**

None identified.

**Warnings:**

None identified.

**Info:**

None.

---

## Patch 6/9: net/i40e: fix SCTP verification tag truncation in FDIR

**Errors:**

None identified.

**Warnings:**

None identified.

**Info:**

None.

---

## Patch 7/9: net/i40e: validate raw FDIR offsets and lengths

**Errors:**

None identified.

**Warnings:**

None identified.

**Info:**

None.

---

## Patch 8/9: net/i40e: disable tunnel replacement in multi-driver mode

**Errors:**

None identified.

**Warnings:**

None identified.

**Info:**

None.

---

## Patch 9/9: net/i40e: allow L2 and L3 only hash patterns

**Errors:**

None identified.

**Warnings:**

None identified.

**Info:**

None.

---

Review-Result: CLEAN