|SUCCESS| [v1,1/1] net/ixgbe: fix EEPROM read callback check

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172286

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-30

# DPDK Patch Review

## Summary

This patch fixes a copy-paste error in the ixgbe driver's EEPROM handlers where the NULL check for the write callback was incorrectly placed in the read handler.

## Errors

None identified.

## Warnings

None identified.

## Info

### 1. Pre-existing: Missing NULL check for read_buffer callback dereference

**File:** `drivers/net/intel/ixgbe/ixgbe_ethdev.c`

**Context:** This is pre-existing code that the patch does not modify.

After the added NULL check at line 7019, the read path continues to call `eeprom->ops.read_buffer` at line 7025 (not shown in patch but present in the function). The patch correctly adds the NULL check, but if `read_buffer` were NULL, the function would return `-ENOTSUP` before reaching any dereference, so this is safe.

Similarly, in `ixgbe_set_eeprom`, after the moved NULL check at line 7050, the code presumably calls `eeprom->ops.write_buffer`. The check correctly prevents the dereference.

**Note:** This is an observation about the surrounding code pattern, not an issue with the patch itself.

## Review Assessment

The patch correctly addresses the bug identified in the commit message:
- Moves the `write_buffer` NULL check from the read handler to the write handler (lines 7050-7051)
- Adds the missing `read_buffer` NULL check in the read handler (line 7019)

Both handlers now check the appropriate callback before use, preventing the NULL dereference described in the original bug fix commit.

The code follows DPDK style guidelines:
- Explicit NULL comparison is used (`== NULL`)
- Proper indentation and formatting
- Error code `-ENOTSUP` is appropriate for unsupported operations

The fix is minimal, correct, and addresses exactly the issue described.

Review-Result: CLEAN