|WARNING| [v2] vhost: remove dependency on PCI library

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Tue Sep 1 09:32:46 CEST 2026


Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168797

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-01

# DPDK Patch Review

## Patch Summary
This patch removes the PCI library dependency from the vhost library and adds it to two examples (vdpa and vhost) that still need it.

## Review Findings

### Errors

None identified.

### Warnings

**Missing release notes:**
The patch removes a public dependency from the vhost library (pci library is no longer required by applications using vhost).
This is an API-level change that affects how applications must be built when using the vhost library.
Release notes should be added to document this change.

**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_26_XX.rst` (current release) under "API Changes" or "Removed Items":

```rst
* **vhost: Removed PCI library dependency.**

  The vhost library no longer depends on the PCI library.
  Applications that directly use PCI functions must now explicitly
  add ``pci`` to their dependencies.
```

### Info

The patch correctly identifies that the vhost library itself no longer needs PCI after the async datapath switched to dmadev, but the two example applications (vdpa and vhost) do still use PCI directly, so adding the dependency there is appropriate.

The `Fixes:` tag correctly references the commit that removed the PCI usage from vhost.

### Summary

The code changes are correct. The patch adds explicit PCI dependencies to examples that need them and removes the dependency from the vhost library which no longer uses PCI directly. However, release notes should be added to document this change in build dependencies for applications using the vhost library.


More information about the test-report mailing list