|WARNING| [v2] examples/ptp_tap_relay_sw: fix build inclusion
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Wed Sep 2 17:56:52 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168935
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-02
# DPDK Patch Review
## Patch Summary
This patch adds the `ptp_tap_relay_sw` example to the meson build system. The example was previously committed but not wired into the build.
---
## FINDINGS
### Errors
None.
### Warnings
**W1: Missing release notes update**
The patch fixes a build issue where a new example directory was not included in the build system. This should be documented in the release notes under "Fixed Issues" for the current release.
**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_26_03.rst` (or the appropriate current release file):
```rst
* **Fixed ptp_tap_relay_sw example build.**
Added the ``ptp_tap_relay_sw`` example to the meson build system.
The example directory was present but not being built.
```
---
## CORRECTNESS REVIEW
**Resource management:** No dynamic allocations or resources in this patch.
**Error paths:** Not applicable (build system change only).
**Shared variables:** Not applicable.
**API usage:** The patch correctly adds the directory name to the alphabetically-sorted `all_examples` list in `examples/meson.build`, matching the existing pattern.
---
## STYLE REVIEW
**Naming and ordering:** The entry `'ptp_tap_relay_sw'` is correctly placed in alphabetical order between `'pipeline'` and `'ptpclient'`.
**Formatting:** The patch uses the same indentation and quote style as surrounding entries.
**Forbidden tokens:** None present.
---
## PROCESS REVIEW
**Fixes tag:** Present and correct - references the commit that introduced the example.
**Cc: stable:** Present and appropriate for a build fix.
**Commit message:** Clear and accurate (not reviewed per guidelines).
---
## CONCLUSION
This is a straightforward build system fix. The code change is correct and follows DPDK conventions. The only issue is the missing release notes update, which is a Warning-level concern since build fixes affecting examples should be documented.
More information about the test-report
mailing list