|WARNING| [6/6] eventdev/dma: promote adapter API to stable

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Wed Sep 2 18:17:57 CEST 2026


Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168941

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-02

# DPDK Patch Review

## Summary
This patch series promotes several eventdev adapter APIs from experimental to stable status. The APIs have been stable since v23.03 or v23.11 with no changes since their introduction.

---

## PATCH 1/6: eventdev/eth_rx: promote adapter API to stable

### Findings

**Errors:** None

**Warnings:** None

**Info:**
- The patch correctly removes `__rte_experimental` tags from header functions
- Export macros properly updated from `RTE_EXPORT_EXPERIMENTAL_SYMBOL` to `RTE_EXPORT_SYMBOL`
- Release notes appropriately updated in the current release file (26.11)
- Functions being promoted (runtime params init/set/get, create_ext_with_params) have been stable since v23.03 and v23.11 as claimed
- Note in commit message correctly states `rte_event_eth_rx_adapter_queues_add()` remains experimental (added v25.03)

---

## PATCH 2/6: eventdev/eth_tx: promote adapter runtime params to stable

### Findings

**Errors:** None

**Warnings:** None

**Info:**
- Correctly removes `__rte_experimental` from runtime parameter functions
- Export macros properly updated from `RTE_EXPORT_EXPERIMENTAL_SYMBOL` to `RTE_EXPORT_SYMBOL`
- Release notes updated appropriately
- Claim that file has "no experimental symbol left" is accurate

---

## PATCH 3/6: eventdev/crypto: promote adapter runtime params to stable

### Findings

**Errors:** None

**Warnings:** None

**Info:**
- Correctly removes `__rte_experimental` from runtime parameter functions
- Export macros properly updated from `RTE_EXPORT_EXPERIMENTAL_SYMBOL` to `RTE_EXPORT_SYMBOL`
- Release notes updated appropriately
- Claim that file has "no experimental symbol left" is accurate

---

## PATCH 4/6: eventdev/timer: promote remaining ticks get to stable

### Findings

**Errors:** None

**Warnings:** None

**Info:**
- Correctly removes `__rte_experimental` from `rte_event_timer_remaining_ticks_get()`
- Export macro properly updated from `RTE_EXPORT_EXPERIMENTAL_SYMBOL` to `RTE_EXPORT_SYMBOL`
- Release notes updated appropriately
- Claim that file has "no experimental symbol left" is accurate

---

## PATCH 5/6: eventdev: promote link profile API to stable

### Findings

**Errors:** None

**Warnings:** None

**Info:**
- Correctly removes `__rte_experimental` from link profile functions
- Export macros properly updated from `RTE_EXPORT_EXPERIMENTAL_SYMBOL` to `RTE_EXPORT_SYMBOL`
- Release notes updated appropriately
- Functions being promoted have been stable since v23.11 as claimed

---

## PATCH 6/6: eventdev/dma: promote adapter API to stable

### Findings

**Errors:** None

**Warnings:** None

**Info:**
- Correctly removes `__rte_experimental` from all DMA adapter functions
- Correctly removes experimental warning from file-level documentation block
- Export macros properly updated from `RTE_EXPORT_EXPERIMENTAL_SYMBOL` to `RTE_EXPORT_SYMBOL` for all functions
- Release notes updated appropriately
- Functions being promoted have been stable since v23.11 as claimed
- `rte_event_dma_adapter_caps_get()` in `rte_eventdev.c` also promoted (was in different file)

---

## Overall Assessment

This is a clean patch series with no correctness issues, style violations, or guideline non-compliance. All patches:
- Follow DPDK coding style
- Use correct symbol export macros
- Update release notes appropriately (current release only)
- Remove experimental tags from headers and update export symbols atomically
- Claims about API stability timelines are accurate

The series is ready for acceptance.


More information about the test-report mailing list