|SUCCESS| [2/2] examples/vhost: remove unused but set globals
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Sep 3 21:39:30 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/169081
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-03
# DPDK Patch Review
## Patch 1/2: examples/qos_sched: fix unused but set global errors
### Errors
None.
### Warnings
None.
### Info
None.
**Summary:** This patch removes dead code (unused global variables `app_numa_mask` and `app_used_port_mask`) that triggered compiler warnings. The changes are correct: the variables are set but never read, and their removal does not affect functionality.
---
## Patch 2/2: examples/vhost: remove unused but set globals
### Errors
None.
### Warnings
None.
### Info
None.
**Summary:** This patch removes the unused global variable `num_queues` and the intermediate variable `num_vmdq_queues` that only fed it. The changes are correct: `num_queues` was computed but never used, and removing it simplifies the code without affecting functionality.
---
## Overall Assessment
Both patches are straightforward dead code removal fixes that address compiler warnings about unused-but-set variables. The changes are correct and do not introduce any issues:
1. **Correctness:** No resource leaks, use-after-free, race conditions, or other bugs introduced
2. **Style compliance:** Changes follow DPDK coding standards
3. **Completeness:** Variables are removed from all relevant locations (declarations, assignments, and one extern declaration)
4. **Testing impact:** These are example applications; no functional changes expected
The patches correctly target the stable backport branch (Cc: stable at dpdk.org) as they fix build warnings without changing behavior.
More information about the test-report
mailing list