|WARNING| app/testpmd: fix stale queue-count check order

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169102

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-04

# DPDK Patch Review

## Patch Summary
The patch reorders two function calls in testpmd's queue configuration path to fix a bug where stale cached device information causes valid queue counts to be rejected.

---

## CORRECTNESS BUGS

None identified. The patch addresses a logic error but does not introduce new correctness issues.

---

## CODE STYLE

### Error

**Unnecessary blank lines around function call**
```c
init_port_config();

fwd_config_setup();

cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1);
```
DPDK style does not require blank lines between consecutive function calls in a sequence. The blank lines before and after `fwd_config_setup()` should be removed for consistency with the rest of the codebase.

**Suggested fix:**
```c
init_port_config();
fwd_config_setup();
cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1);
```

---

## API AND DOCUMENTATION

### Error

**Missing release notes update**
The patch fixes a user-visible bug where valid queue counts are rejected due to stale cached device info. This affects users who change queue limits at runtime (e.g., via `rte_tm` hierarchy commit). A fix of this nature should be documented in the release notes under the "Fixed Issues" section for the application.

**Suggested addition to `doc/guides/rel_notes/release_26_XX.rst`:**
```rst
* **Fixed testpmd queue count validation against stale limits.**

  Fixed an issue in testpmd where setting queue counts via
  ``port config all txq/rxq`` could incorrectly reject valid values
  when a PMD's reported queue limits changed after initial probing
  (e.g., after a traffic management hierarchy commit).
```

---

## PROCESS COMPLIANCE

### Info

**Fixes tag format is correct**
The `Fixes:` tag references commit `0c0db76f42ed` and includes `Cc: stable at dpdk.org`, which is appropriate for a backportable bug fix.

---

## SUMMARY

**Errors: 2**
- Unnecessary blank lines (style)
- Missing release notes update

**Warnings: 0**

**Info: 0**

The core logic change (swapping the order of `init_port_config()` and `fwd_config_setup()`) is correct and addresses the described bug. The commit message clearly explains the problem and the fix. The issues identified are minor: a style inconsistency with blank lines and the absence of a release notes entry for a user-visible bug fix.