|SUCCESS| [7/7] net/vmxnet3: remove unused queue dump functions

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/169112

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-04

# DPDK Patch Review

## PATCH 1/7: bus/fslmc: fix build of qbman debug code

### Errors
None

### Warnings
None

### Info
- Clean fix for a build failure in debug code
- Correctly defines `QBMAN_RESPONSE_VERB_MASK` locally with appropriate comment
- The patch targets debug-only code (`RTE_LIBRTE_DPAA2_DEBUG_BUS`)

---

## PATCH 2/7: bus/fslmc: fix signed comparison in buffer acquire

### Errors
None

### Warnings
None

### Info
- Clean fix for a sign-compare warning
- The variable `num` is masked with `BMAN_VALID_RSLT_NUM_MASK` (limiting it to 0..7) and compared against `num_buffers` (unsigned parameter)
- Changing `num` to `unsigned int` is the correct fix
- Error paths returning negative errno are unaffected (they return directly, not through `num`)

---

## PATCH 3/7: crypto/caam_jr: fix descriptor dump build

### Errors
None

### Warnings
None

### Info
- Fixes three issues in debug code:
  1. `SEC_DUMP_DESC()` macro call site missing the new `FILE *` argument
  2. Log format string ends in newline (rejected by `RTE_LOG_LINE()`)
  3. Pointer cast to `uint32_t` truncates on 64-bit
- All fixes are correct
- The newline removal from `CAAM_JR_INFO()` is correct -- `RTE_LOG_LINE()` appends one automatically
- Pointer formatting changed to `%p` with explicit `(const void *)` cast, which is correct

---

## PATCH 4/7: crypto/ipsec_mb: fix missing header for debug build

### Errors
None

### Warnings
None

### Info
- Adds missing `#include <rte_hexdump.h>` for `rte_hexdump()` used in debug code
- Clean fix for implicit declaration

---

## PATCH 5/7: power/amd_uncore: fix debug log build

### Errors
None

### Warnings
None

### Info
- Fixes copy-paste error: `ui->num_uncore_freqs` (Intel field name) - `ui->nb_freqs` (AMD field name)
- Debug log now matches the actual structure field

---

## PATCH 6/7: net/rnp: fix register debug log format

### Errors
None

### Warnings
None

### Info
- Fixes format specifier mismatch: `size_t` offset was printed with `%p` (pointer format)
- Changed to `%#zx` (hex size_t with 0x prefix), which is correct and matches the intent (printing offset as hex)

---

## PATCH 7/7: net/vmxnet3: remove unused queue dump functions

### Errors
None

### Warnings
None

### Info
- Removes dead code guarded by `RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED`
- The macro is undefined and its name explicitly records that the code is unused
- Clean removal of dead debug code

---

## Summary

All seven patches are clean fixes for debug/conditional compilation code. No correctness bugs, style issues, or guideline violations detected. The patches do not require release notes (debug-only/build-fix changes to non-public code paths).

**Recommendation**: Accept all patches as-is.